-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for capturing asset in multiple dpr and width combination #1536
Merged
+268
−68
Merged
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
eb9847d
Intial implementation
chinmay-browserstack a7e10e4
Capture for passed widths
chinmay-browserstack 61113a9
Added support for image srcset capturing
chinmay-browserstack b62f174
Added tests + addressed comments
chinmay-browserstack 9877cc3
Fix breaking tests
chinmay-browserstack 91e1b17
Merge remote-tracking branch 'origin/capture_srcset_support' into mul…
chinmay-browserstack b90df23
Capture responsive dom
chinmay-browserstack dade996
Fix logic
chinmay-browserstack 2c31be6
Remove new flag and use existing + enableJS
chinmay-browserstack 11d8aff
Added endpoint for deviceDetails + deprecate deviceScaleFactor
chinmay-browserstack 3bad053
Fix sdk-utils testcases
chinmay-browserstack 5e46151
Fix breaking test
chinmay-browserstack 45e1625
Add test for getDeviceDetails
chinmay-browserstack 2eeef07
Added tests for captureResponsiveDom
chinmay-browserstack 901d936
Fix edge case
chinmay-browserstack c9f1b43
Add warning remove tests
chinmay-browserstack 7fe9bdb
Fix tests
chinmay-browserstack 957bc8a
Fix tests
chinmay-browserstack fe4980f
addressed comments
chinmay-browserstack 9897bad
Added new testcase
chinmay-browserstack d808e07
handle for snapshot command
chinmay-browserstack 240b409
Merge remote-tracking branch 'origin/master' into multi_dpr_width_cap…
chinmay-browserstack File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns list only correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes