✨ Discovery retry support + fixed a race condition in network handling

lerna.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "packages": [
     "packages/*"
   ],

packages/cli-app/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-app",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -33,7 +33,7 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.28.1-beta.0",
-    "@percy/cli-exec": "1.28.1-beta.0"
+    "@percy/cli-command": "1.28.1-alpha.1",
+    "@percy/cli-exec": "1.28.1-alpha.1"
   }
 }

packages/cli-build/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-build",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -33,6 +33,6 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.28.1-beta.0"
+    "@percy/cli-command": "1.28.1-alpha.1"
   }
 }

packages/cli-command/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-command",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "files": [
     "dist",
@@ -36,8 +36,8 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/config": "1.28.1-beta.0",
-    "@percy/core": "1.28.1-beta.0",
-    "@percy/logger": "1.28.1-beta.0"
+    "@percy/config": "1.28.1-alpha.1",
+    "@percy/core": "1.28.1-alpha.1",
+    "@percy/logger": "1.28.1-alpha.1"
   }
 }

packages/cli-config/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-config",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -33,6 +33,6 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.28.1-beta.0"
+    "@percy/cli-command": "1.28.1-alpha.1"
   }
 }

packages/cli-exec/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-exec",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -33,7 +33,7 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.28.1-beta.0",
+    "@percy/cli-command": "1.28.1-alpha.1",
     "cross-spawn": "^7.0.3",
     "which": "^2.0.2"
   }

packages/cli-snapshot/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-snapshot",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -33,7 +33,7 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.28.1-beta.0",
+    "@percy/cli-command": "1.28.1-alpha.1",
     "yaml": "^2.0.0"
   }
 }

packages/cli-upload/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli-upload",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -33,7 +33,7 @@
     ]
   },
   "dependencies": {
-    "@percy/cli-command": "1.28.1-beta.0",
+    "@percy/cli-command": "1.28.1-alpha.1",
     "fast-glob": "^3.2.11",
     "image-size": "^1.0.0"
   }

packages/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/cli",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "files": [
     "bin",
@@ -31,14 +31,14 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/cli-app": "1.28.1-beta.0",
-    "@percy/cli-build": "1.28.1-beta.0",
-    "@percy/cli-command": "1.28.1-beta.0",
-    "@percy/cli-config": "1.28.1-beta.0",
-    "@percy/cli-exec": "1.28.1-beta.0",
-    "@percy/cli-snapshot": "1.28.1-beta.0",
-    "@percy/cli-upload": "1.28.1-beta.0",
-    "@percy/client": "1.28.1-beta.0",
-    "@percy/logger": "1.28.1-beta.0"
+    "@percy/cli-app": "1.28.1-alpha.1",
+    "@percy/cli-build": "1.28.1-alpha.1",
+    "@percy/cli-command": "1.28.1-alpha.1",
+    "@percy/cli-config": "1.28.1-alpha.1",
+    "@percy/cli-exec": "1.28.1-alpha.1",
+    "@percy/cli-snapshot": "1.28.1-alpha.1",
+    "@percy/cli-upload": "1.28.1-alpha.1",
+    "@percy/client": "1.28.1-alpha.1",
+    "@percy/logger": "1.28.1-alpha.1"
   }
 }

packages/client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/client",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -32,7 +32,7 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/env": "1.28.1-beta.0",
-    "@percy/logger": "1.28.1-beta.0"
+    "@percy/env": "1.28.1-alpha.1",
+    "@percy/logger": "1.28.1-alpha.1"
   }
 }

packages/config/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/config",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -38,7 +38,7 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/logger": "1.28.1-beta.0",
+    "@percy/logger": "1.28.1-alpha.1",
     "ajv": "^8.6.2",
     "cosmiconfig": "^8.0.0",
     "yaml": "^2.0.0"

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/core",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -43,11 +43,11 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/client": "1.28.1-beta.0",
-    "@percy/config": "1.28.1-beta.0",
-    "@percy/dom": "1.28.1-beta.0",
-    "@percy/logger": "1.28.1-beta.0",
-    "@percy/webdriver-utils": "1.28.1-beta.0",
+    "@percy/client": "1.28.1-alpha.1",
+    "@percy/config": "1.28.1-alpha.1",
+    "@percy/dom": "1.28.1-alpha.1",
+    "@percy/logger": "1.28.1-alpha.1",
+    "@percy/webdriver-utils": "1.28.1-alpha.1",
     "content-disposition": "^0.5.4",
     "cross-spawn": "^7.0.3",
     "extract-zip": "^2.0.1",

packages/core/src/network.js

@@ -31,6 +31,7 @@ export class Network {
   #requests = new Map();
   #authentications = new Set();
   #aborted = new Set();
+  #finishedUrls = new Set();
 
   constructor(page, options) {
     this.page = page;
@@ -86,6 +87,13 @@ export class Network {
       }
 
       requests = Array.from(this.#requests.values()).filter(filter);
+      // remove requests which are finished at least once
+      // this happens when same request is made multiple times by browser in parallel and one of
+      // them gets stuck in pending state in browser [ need to debug why ]. So we dont receive
+      // loadingFinished event, causing it to show up in Active requests, but we can only store one
+      // response per url so as long as we have captured one, we dont care about other such requests
+      requests = requests.filter((req) => !this.#finishedUrls.has(req.url));
+
       return requests.length === 0;
     }, {
       timeout: Network.TIMEOUT,
@@ -131,9 +139,10 @@ export class Network {
   }
 
   // Called when a request should be removed from various trackers
-  _forgetRequest({ requestId, interceptId }, keepPending) {
+  _forgetRequest({ requestId, interceptId, url }, keepPending) {
     this.#requests.delete(requestId);
     this.#authentications.delete(interceptId);
+    this.#finishedUrls.add(url);
 
     if (!keepPending) {
       this.#pending.delete(requestId);

packages/dom/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/dom",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "main": "dist/bundle.js",
   "browser": "dist/bundle.js",

packages/env/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/env",
-  "version": "1.28.1-beta.0",
+  "version": "1.28.1-alpha.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "beta"
+    "tag": "alpha"
   },
   "engines": {
     "node": ">=14"
@@ -32,6 +32,6 @@
     "test:coverage": "yarn test --coverage"
   },
   "dependencies": {
-    "@percy/logger": "1.28.1-beta.0"
+    "@percy/logger": "1.28.1-alpha.1"
   }
 }