Using action

percy · May 17, 2024 · 8c28a69 · 8c28a69
1 parent c608dd5
commit 8c28a69
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 15 deletions.
diff --git a/.github/workflows/executable.yml b/.github/workflows/executable.yml
@@ -42,10 +42,16 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: win-exe
-      - run: |
-          echo ${{ secrets.WINDOWS_CERT }} | base64.exe -d > CodeSigning.p12
-          signtool.exe sign /fd SHA256 /f CodeSigning.p12 /p "${{ secrets.WINDOWS_CERT_KEY }}" percy.exe
-          powershell Compress-Archive -Path percy.exe -DestinationPath percy-win.zip
+      # - run: |
+      #     echo ${{ secrets.WINDOWS_CERT }} | base64.exe -d > CodeSigning.p12
+      #     signtool.exe sign /fd SHA256 /f CodeSigning.p12 /p "${{ secrets.WINDOWS_CERT_KEY }}" percy.exe
+      #     powershell Compress-Archive -Path percy.exe -DestinationPath percy-win.zip
+      - name: Sign binary
+        uses: lando/code-sign-action@v2
+        with:
+          file: ./percy.exe
+          certificate-data: ${{ secrets.WINDOWS_CERT }}
+          certificate-password: ${{ secrets.WINDOWS_CERT_KEY }}
       - name: Verify executable
         run: ./percy.exe --version
       # - name: Upload assets

diff --git a/scripts/executable.sh b/scripts/executable.sh
@@ -52,24 +52,24 @@ mv run-linux percy && chmod +x percy
 mv run-macos percy-osx && chmod +x percy-osx
 mv run-win.exe percy.exe && chmod +x percy.exe
 
-# Sign & Notrize mac app
-echo "$APPLE_DEV_CERT" | base64 -d > AppleDevIDApp.p12
+# # Sign & Notrize mac app
+# echo "$APPLE_DEV_CERT" | base64 -d > AppleDevIDApp.p12
 
-security create-keychain -p percy percy.keychain
-security import AppleDevIDApp.p12 -t agg -k percy.keychain -P ChaiTime -A
-security list-keychains -s ~/Library/Keychains/percy.keychain
-security default-keychain -s ~/Library/Keychains/percy.keychain
-security unlock-keychain -p "percy" ~/Library/Keychains/percy.keychain
-security set-keychain-settings -t 3600 -l ~/Library/Keychains/percy.keychain
-security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k percy ~/Library/Keychains/percy.keychain-db
+# security create-keychain -p percy percy.keychain
+# security import AppleDevIDApp.p12 -t agg -k percy.keychain -P ChaiTime -A
+# security list-keychains -s ~/Library/Keychains/percy.keychain
+# security default-keychain -s ~/Library/Keychains/percy.keychain
+# security unlock-keychain -p "percy" ~/Library/Keychains/percy.keychain
+# security set-keychain-settings -t 3600 -l ~/Library/Keychains/percy.keychain
+# security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k percy ~/Library/Keychains/percy.keychain-db
 
-codesign  --force --verbose=4 -s "Developer ID Application: BrowserStack Inc (763K6K6H44)" --options runtime --entitlements scripts/files/entitlement.plist --keychain ~/Library/Keychains/percy.keychain percy-osx
+# codesign  --force --verbose=4 -s "Developer ID Application: BrowserStack Inc (763K6K6H44)" --options runtime --entitlements scripts/files/entitlement.plist --keychain ~/Library/Keychains/percy.keychain percy-osx
 
 # Create zip file for uploading as assets
 zip percy-linux.zip percy
 mv percy-osx percy
 zip percy-osx.zip percy
 
-xcrun notarytool submit --apple-id "$APPLE_ID_USERNAME" --password $APPLE_ID_KEY --team-id 763K6K6H44 percy-osx.zip --wait
+# xcrun notarytool submit --apple-id "$APPLE_ID_USERNAME" --password $APPLE_ID_KEY --team-id 763K6K6H44 percy-osx.zip --wait
 
 cleanup