-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pin/unpin messages #2692
Merged
Merged
feat: pin/unpin messages #2692
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuyuribr
approved these changes
Dec 15, 2023
Worked here |
shirser121
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Applying this seems to cause an issue if you have already installed #2596 (Poll voting feature). |
Hi, How can I know if a message is pinned or not? |
This was referenced Sep 8, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table of Contents
- Description
- Related Issues
- Usage Example
- I Want to Test this PR
- I Got an Error While Testing This PR ❌
- How Has the PR Been Tested (latest test on 15.12.2023)
- Types of Changes
Description
The PR adds functionality to pin and unpin messages in chats, groups and communities.
While pinning a message, the user has to provide a value in seconds for that message to be pinned in a chat.
Related Issues
The PR closes #2690
Usage Example
To test this PR by yourself you can run one of the following commands:
If you encounter any errors while testing this PR, please provide in a comment:
console.log(await client.getWWebVersion());
Important
You have to reapply the PR each time it is changed (new commits were pushed since your last application)
How Has The PR Been Tested (latest test on 15.12.2023)
Tested with all possible scenarious.
In the case provided in usage example can be seen the scenario where the current user, possibly acting as a group admin, pins a message sent by another group member. Following this, the current user sends a message '!unpin' that quotes the previously pinned message, thus unpinning that pinned message.
Tested On:
Types of accounts:
Environment:
Types of Changes
Checklist