-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: group mentions + improved user mentions #2602
Conversation
Using TypeScript, I can't use groupMentions as a MessageSendOption while calling the function client.SendMessage. Line 802-817 in Client.js should contain property groupMentions to fix this (I think). @alechkos |
You are right, I forgot to add this |
Lemme know when you plan on fixing this! Using it for a project of mine :D |
@crash-overdrive |
1d20b3e
to
7468c94
Compare
is this ready for merge? I am waiting for this to include in my project. |
Yes it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Table of Contents
- Description
- Usage Example
- I Want to Test this PR
- I Got an Error While Testing This PR ❌
- How Has the PR Been Tested (latest test on 04.12.2023)
- Types of Changes
Description
This PR introduces logic for mentioning groups in messages and improves the logic for mentioning users:
Message.getGroupMentions
method to get an array ofGroupChat
objects from a message with group mentionsUsage Example
To test this PR by yourself you can run one of the following commands:
If you encounter any errors while testing this PR, please provide in a comment:
console.log(await client.getWWebVersion());
Important
You have to reapply the PR each time it is changed (new commits were pushed since your last application)
How Has The PR Been Tested (latest test on 04.12.2023)
Tested with a code provided in usage example.
Tested On:
Types of accounts:
Environment:
Types of Changes
Checklist