FISH-8545 SameSite Cookie #7199
Conversation
| @@ -636,7 +636,7 @@ protected void read(InputStream input) throws XMLStreamException { | |||
| versionIdentifier = parser.getElementText(); | |||
| } else if (RuntimeTagNames.PAYARA_WHITELIST_PACKAGE.equals(name)) { | |||
| application.addWhitelistPackage(parser.getElementText()); | |||
| } else if ("cookie-properties".equals(name)) { | |||
| } else if ("session-config".equals(name)) { | |||
There was a problem hiding this comment.
Could this be a constant value instead to compare literal value directly?
| @@ -2072,6 +2072,8 @@ private void configureCookieProperties(CookieProperties bean) { | |||
| cookieConfig.setSecure(value); | |||
| } else if("cookieHttpOnly".equalsIgnoreCase(name)) { | |||
| cookieConfig.setHttpOnly(Boolean.valueOf(value)); | |||
| } else if("cookieSameSite".equalsIgnoreCase(name)) { | |||
There was a problem hiding this comment.
probably same here move the literal value to a constant and then compare
| @@ -282,6 +293,10 @@ public String toString() { | |||
| sb.append(", domain="); | |||
| sb.append(_domain); | |||
| } | |||
| if (sameSite != null) { | |||
| sb.append(", sameSite="); | |||
There was a problem hiding this comment.
here also split more the append calls and use sameSite literal value on a constant
|
@Viii3 I tested the cookie is there but when selecting any of the values from the console on the SameSite value it is always set strict either if you select none or lax from the admin console
|
|
The cookie value in question is set on the application level, the admin console sets the value globally instead. The documentation does not specify, but I would presume the application settings are intended to override the global settings. |
|
little comments but in general this is working as expected |
FISH-8545 SameSite Cookie
FISH-8545 SameSite Cookie
FISH-8545 SameSite Cookie
Description
Important Info
Blockers
Testing
New tests
Testing Performed
Tested against the reproducer.
Testing Environment
Maven version: 3.9.6
Java version: 11.0.23, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
Documentation
Notes for Reviewers