Merge pull request #51 from libitx/main

Ensure blake3 inputs are immutable
paulmillr · Apr 27, 2023 · 15d067e · 15d067e
2 parents 5ee1bce + 21cbc80
commit 15d067e
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 1 deletion.
diff --git a/src/blake3.ts b/src/blake3.ts
@@ -70,9 +70,10 @@ class BLAKE3 extends BLAKE2<BLAKE3> implements HashXOF<BLAKE3> {
       this.IV = u32(context_key);
       this.flags = flags | Flags.DERIVE_KEY_MATERIAL;
     } else {
-      this.IV = IV.slice();
+      this.IV = IV;
       this.flags = flags;
     }
+    this.IV = this.IV.slice();
     this.state = this.IV.slice();
     this.bufferOut = u8(this.bufferOut32);
   }

diff --git a/test/blake.test.js b/test/blake.test.js
@@ -119,4 +119,47 @@ should('Blake3 XOF', () => {
   assert.deepStrictEqual(concatBytes(...out), bigOut, 'xof check against fixed size');
 });
 
+should('BLAKE2b inputs are immuatable', () => {
+  const msg = new Uint8Array([1, 2, 3, 4]);
+  const key = new Uint8Array([1, 2, 3, 4]);
+  const pers = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8]);
+  const salt = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8]);
+  blake2b(msg, { key, salt, personalization: pers });
+  assert.deepStrictEqual(msg, new Uint8Array([1, 2, 3, 4]));
+  assert.deepStrictEqual(key, new Uint8Array([1, 2, 3, 4]));
+  assert.deepStrictEqual(pers, new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8]));
+  assert.deepStrictEqual(salt, new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8]));
+});
+
+should('BLAKE2s inputs are immuatable', () => {
+  const msg = new Uint8Array([1, 2, 3, 4]);
+  const key = new Uint8Array([1, 2, 3, 4]);
+  const pers = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]);
+  const salt = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]);
+  blake2s(msg, { key, salt, personalization: pers });
+  assert.deepStrictEqual(msg, new Uint8Array([1, 2, 3, 4]));
+  assert.deepStrictEqual(key, new Uint8Array([1, 2, 3, 4]));
+  assert.deepStrictEqual(pers, new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]));
+  assert.deepStrictEqual(salt, new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]));
+});
+
+should('BLAKE3 inputs are immuatable', () => {
+  const msg = new Uint8Array([1, 2, 3, 4]);
+  const ctx = new Uint8Array([1, 2, 3, 4]);
+  const key = new Uint8Array([
+    1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8,
+  ]);
+  blake3(msg, { key });
+  blake3(msg, { context: ctx });
+  assert.deepStrictEqual(msg, new Uint8Array([1, 2, 3, 4]));
+  assert.deepStrictEqual(ctx, new Uint8Array([1, 2, 3, 4]));
+  assert.deepStrictEqual(
+    key,
+    new Uint8Array([
+      1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 3, 4, 5, 6, 7,
+      8,
+    ])
+  );
+});
+
 if (require.main === module) should.run();