Fix filter pattern not being applied to files inside symlink subdirectories of the watched path #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll address those issues, assuming they're real issues (lint at least probably is). 👍 |
|
@paulmillr It looks like none of the errors are actually related to my PR but are existing issues. This particular one is with DTS Lint and a missing function. |
|
As i’ve mentioned, we can’t really merge new code unless we fix the old tests. Otherwise some stuff could get broken and we wouldn’t even know. Thanks for the pr. |
|
Thanks for the update. I missed that specific message about the tests. I'll work on those next. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #967 and applies the pattern filter to files nested inside symlinks.
No change in expected behavior or usage. New passing test added.