Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some tests #1242

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Fix some tests #1242

merged 2 commits into from
Aug 19, 2022

Commits on Aug 19, 2022

  1. Fix close tests 

    Avoid nested async/await and Promise constructors that caused parts of
the old tests to continue running and interfere with subsequent tests
    @zqianem
    zqianem committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    62b19c9 View commit details
    Browse the repository at this point in the history

  2. Fix test case using unsupported option for Node 8 

    The `fs.mkdir` function does not take an `options` object until Node 10
    @zqianem
    zqianem committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    66ed188 View commit details
    Browse the repository at this point in the history