Allow disabling quickstart panel grabbing focus #300
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for quickstarts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nicolethoen
approved these changes
Jun 17, 2024
|
🎉 This PR is included in version 5.4.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on an application that provides a UI for people making QuickStart files. As part of this, I'm trying to use
QuickStartDrawerto render a preview of the QuickStart. However, if the QuickStart is a QuickStart with tasks, thus opening the side panel, whenever the values in the QuickStart are changed, the panel grabs focus.For instance, if I have a textbox that allows editing the description of a QuickStart, the user will enter a character into the textbox. That will result in the QuickStart being changed in the
QuickStartContext. This will propagate down toQuickStartPaneland trigger this hook and pull focus to the panel, away from the textbox the user was editing.To allow working around this, I am proposing to allow disabling everything that pulls focus to the panel with a new value in
QuickStartContext. This value defaults to the status quo to preserve backwards-compatibility.