Remove runtime dependency on base64 gem to fix Ruby 3.3 warning #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
changed the title
mattbrictson
force-pushed
the
bugs/base64
branch
from
6564a1b
to
e384a00
Compare
apainintheneck
added a commit
to Homebrew/brew
that referenced
this pull request
Dec 28, 2023
This was required previously by the `plist` gem and we were requiring it indirectly. It got removed in v1.7.1 of that gem because it will no longer be included in the standard library as of Ruby 3.4. Since we're not currently running on Ruby 3.3 and 3.4 is not out yet, we can punt on this for now but we'll need to figure out a better alternative before upgrading to Ruby 3.4. Related: - patsplat/plist#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base64 gem will no longer be included with Ruby starting in Ruby 3.4. Starting with Ruby 3.3, a warning is emitted.
The base64 gem is an extremely thin wrapper around
String#packandString#unpack1, so we can use those methods directly and omit the base64 dependency entirely.I left base64 as a development dependency so that our unit tests can remain unchanged. This gives us confidence that no behavior has been changed as a result of this PR.
Fixes this warning: