Add 'submission_id' and 'Kill Sub' columns in New submissions leaderboard

[frcaud]

Adding a Kill Submission button in New submissions leaderboard to be able to terminate a submission.
First PR is adding a 'submission_id' column and adding a 'Kill Sub' column with clickable buttons on the HTML rendering of the New submissions leaderboard (leaderboard and My submissions pages on frontend)

[rth]

Thanks @frcaud! That's the idea, though we need to figure out why CI fails and fix it.

[glemaitre]

My first guess (looking at the last history commit in main) would be to check the pytest. I would assume that this PR is using the latest pytest and they might have issue deprecation warning about the way we used the fixture and we did not change it on time.

[glemaitre]

I see that pytest==6.2.5 does not raise the error for the fixture. So it should be something new.

The conftest.py file is here:

ramp-board/conftest.py

Line 11 in 9b1d738

def database_connection():

[glemaitre]

It might be due to pytest-dev/pytest#11261

[glemaitre]

You need to add an empty pytest.ini in the root folder

[frcaud]

Thanks @glemaitre !
Frontend error is resolved.
Still some issue on test database

[rth]

Thanks @frcaud ! For the failing test we need to edit test_get_leaderboard to add the extra column we added in,

>       assert (
            """<th>team</th>
          <th>submission</th>
          <th>submitted at (UTC)</th>
          <th>error</th>"""
            in leaderboard_failed
        )

assertion. The pytest log is a bit confusing, but I think that's actually the only failing test. The other exceptions you see in the logs, are the expected exceptions that are obtained when running a bad submission and can be ignored.

A few more comments below, otherwise LGTM.

[rth]

Maybe let's just call it id so it would be a less wide column in the resulting html table? It's shown under a section of New submission, so there is no need to repeat "submission" in column names I think.

[rth]

Again just "Kill" or maybe better "Stop" would be enough. It's in a table of submissions already.

[rth]

I think if leaderboard_type not in ['new', 'failed'] we need to delete the extra column "id" we created before _compute_competition_leaderboard is run otherwise it will show in all other leaderboards

[frcaud]

Since we create this extra column in elif leaderboard_type in ["new", "failed"]: it seems that we don't need to delete it in other leaderboard types, or am I mistaken ?

[frcaud]

Thanks @rth ! Tests OK. Seems there is one more error with codecov.

[frcaud]

CIs are green on rerun. Thanks @glemaitre and @rth !

[rth]

Thanks! Linting CI is still failing though. Can you run black on it?