Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source map support to the inline-require optimizer #9511

Merged
merged 2 commits into from Jan 30, 2024
Merged

Add source map support to the inline-require optimizer #9511

merged 2 commits into from Jan 30, 2024

Conversation

mattcompiles
Copy link
Contributor

↪️ Pull Request

Add missing source map support to the inline-require optimizer.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

marcins
marcins approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@marcins marcins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks for doing this.. I thought it was going to be more complicated (like manually having to move around stuff you move around). I really need to learn more depth about how sourcemaps work / are manipulated.

@mattcompiles mattcompiles merged commit 120103a into v2 Jan 30, 2024
14 of 16 checks passed
@mattcompiles mattcompiles deleted the inline-require-source-maps branch January 30, 2024 04:47
lettertwo added a commit that referenced this pull request Jan 30, 2024
@lettertwo
Merge branch v2 into adjacency-list-optimizations
46b8d22 
* upstream/v2: (22 commits)
  Add source map support to the inline-require optimizer (#9511)
  [Web Extension] Add content script world property to manifest schema validation (#9510)
  feat: add getCurrentPackageManager (#9505)
  Default Bundler Contributor Notes (#9488)
  rename parentAsset to root for msb config and remove unstable (#9486)
  Macro errors -> v2 (#9501)
  Statically evaluate constants referenced by macros (#9487)
  Multiple css bundles in Entry bundle groups issue (#9023)
  Fix macro issues (#9485)
  Bump follow-redirects from 1.14.7 to 1.15.4 (#9475)
  Revert more CI changes to centos job (#9472)
  Use lightningcss to implement CSS packager (#8492)
  Fixup CI again (#9471)
  Clippy and use napi's Either3 (#9047)
  Upgrade to eslint 8 (#8580)
  Add support for JS macros (#9299)
  Fixup REPL CI (#9467)
  Drop per-pipeline transformation cache (#9459)
  Upgrade some CI actions (#9466)
  REPL (#9365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcins marcins marcins approved these changes

@JakeLane JakeLane JakeLane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattcompiles @marcins @JakeLane