REPL #9365

mischnic · 2023-11-07T17:32:18Z

https://pr-9365.repl.parceljs.org/

mischnic · 2023-11-11T15:24:02Z

@devongovett So what you need to do is:

Create a Vercel token and set it as REPL_VERCEL_TOKEN
Create a new Vercel project (e.g. deploy an empty folder to a new project) for the REPL
You probably need these settings for that project on vercel.com

From .vercel/project.json take the project and org is and set them as REPL_VERCEL_ORG_ID and REPL_VERCEL_PROJECT_ID

That's used here:

parcel/.github/workflows/ci.yml

Lines 172 to 174 in 0025d0e

    
           vercel-token: ${{ secrets.REPL_VERCEL_TOKEN }} 
        
           vercel-org-id: ${{ secrets.REPL_VERCEL_ORG_ID }} 
        
           vercel-project-id: ${{ secrets.REPL_VERCEL_PROJECT_ID }}

For now, this would then deploy as e.g. https://pr-9365.repl.parceljs.org

parcel/.github/workflows/ci.yml

Line 179 in 0025d0e

pr-{{PR_NUMBER}}.repl.parceljs.org

We can add some deploy-on-merge/nightly/release stuff later

mischnic · 2023-11-12T18:59:17Z

This is what registering the deployment look like in PRs: mischnic#1

devongovett · 2023-11-12T20:29:49Z

@mischnic I added the tokens and uploaded an empty project to repl.parceljs.org. I guess we have to merge the GitHub actions changes first in order to test it?

mischnic · 2023-11-12T20:31:11Z

No, this should work from the PR. It did for mischnic#1

devongovett · 2023-11-12T20:59:52Z

Looks like it failed during Vercel deployment:

error An unexpected error occurred: "https://registry.yarnpkg.com/@parcel%2fconfig-repl: Not found".

mischnic · 2023-11-12T21:00:30Z

Then you probably haven't disabled building on Vercel itself as I've shown in the screenshot here: #9365 (comment) ?

The switches have to be enabled and the input fields have to be empty. Kind of a weird UI

devongovett · 2023-11-12T21:04:22Z

I have this. If I change the override switches but don't fill in a value into the inputs the save button doesn't become enabled...

devongovett · 2023-11-12T21:05:25Z

changed the build command to "echo build" 😂

mischnic · 2023-11-12T21:06:11Z

You're right. But this trick worked for me 🙈

Change "dist" to anything else
Save
Turn on all toggles and make it "dist" again. Then you can save and it does store everything

devongovett · 2023-11-12T21:20:25Z

I think it worked! https://pr-9365.repl.parceljs.org

mischnic · 2023-11-12T21:22:19Z

You have this enabled for the project (probably globally and you need to disable it for the project): https://vercel.com/docs/security/deployment-protection/methods-to-protect-deployments/vercel-authentication#access-requests

devongovett · 2023-11-12T21:31:38Z

ok I turned that off

mischnic · 2023-11-12T21:45:18Z

Great, so we're set now.

Apart from the fact that the TypeError: a.FSCache is not a constructor error you get when using the REPL is apparently a regression from #9331 ...

devongovett

Looks pretty self contained! Will be nice to have this finally merged. 🥳

packages/core/cache/src/LayeredCache.js

devongovett · 2023-11-13T00:04:50Z

packages/core/fs/src/MemoryFS.js

@@ -913,7 +913,7 @@ class Directory extends Entry {
  }
 }

-function makeShared(contents: Buffer | string): Buffer {
+export function makeShared(contents: Buffer | string): Buffer {


Are these exports use somewhere?

Yes:

parcel/packages/dev/repl/src/parcel/ExtendedMemoryFS.js

Line 3 in 8fe737f

import {MemoryFS, FSError, makeShared, File} from '@parcel/fs';

That implements many of the callback and fd based FS operations so that Yarn works

packages/runtimes/hmr-sse/src/loaders/hmr-runtime.js

devongovett · 2023-11-13T00:26:29Z

packages/transformers/react-refresh-wrap/src/ReactRefreshWrapTransformer.js

+const FILENAME = // $FlowFixMe[prop-missing]
+  process.env.PARCEL_BUILD_REPL && process.browser
+    ? '/app/__virtual__/@parcel/transformer-react-refresh-wrap/src/ReactRefreshWrapTransformer.js'
+    : __filename;


Wonder if we should have a lint rule or something to ensure we don't accidentally add __filename or __dirname again? Also, I guess the default browser replacement that parcel does for those doesn't work in this case?

(The problem with the current approach for normal Parcel usage is that runtime assets have a filepath of __filepath and then load require("./loaders/browser/js-loader)from the real filesystem in node_modules. But that filesystem doesn't exist for the REPL, soREPLRuntimesResolver` tries to intercept these dependencies and return the contents of the file. The problem is how to identify these dependencies)

It would be possible to implement this without prefixing all runtime asset paths with /app/__virtual__ (and leave it as is).
But then from the REPLRuntimesResolver perspective (which provides the dependencies of the runtime assets such as the loaders, etc... at runtime), it looks like a dependency with

resolveFrom: '/app/packages/runtimes/js/src/runtime-70a029dfdf59c5ac.js' specifier: './helpers/bundle-manifest'

and this "internal" dependency is not easily distinguishable from a "user" dependency that should just go through the usual resolver AFAICT. Any ideas?

__filename is packages/runtimes/js/src/JSRuntime.js when building the REPL. Which then gets concatenated onto the project root /app to result in the above resolveFrom

I changed this now to simply check for these /app/packages/runtimes/js/src/ paths in the resolver.

mischnic · 2023-12-05T20:21:28Z

packages/runtimes/hmr/src/HMRRuntime.js

+// Without this, the hmr-runtime.js is transpiled with the React Refresh swc transform because it
+// lives in `/app/packages/runtimes/...` and thus the `config` in the JSTransformer is actually the
+// user's package.json, and hmr-runtime.js is transpiled as a JSX asset.
+const FILENAME =
+  // $FlowFixMe
+  process.env.PARCEL_BUILD_REPL && process.browser
+    ? '/' + __filename
+    : __filename;


# Conflicts: # yarn.lock

* upstream/v2: (22 commits) Add source map support to the inline-require optimizer (#9511) [Web Extension] Add content script world property to manifest schema validation (#9510) feat: add getCurrentPackageManager (#9505) Default Bundler Contributor Notes (#9488) rename parentAsset to root for msb config and remove unstable (#9486) Macro errors -> v2 (#9501) Statically evaluate constants referenced by macros (#9487) Multiple css bundles in Entry bundle groups issue (#9023) Fix macro issues (#9485) Bump follow-redirects from 1.14.7 to 1.15.4 (#9475) Revert more CI changes to centos job (#9472) Use lightningcss to implement CSS packager (#8492) Fixup CI again (#9471) Clippy and use napi's Either3 (#9047) Upgrade to eslint 8 (#8580) Add support for JS macros (#9299) Fixup REPL CI (#9467) Drop per-pipeline transformation cache (#9459) Upgrade some CI actions (#9466) REPL (#9365) ...

mischnic added 8 commits November 7, 2023 18:26

REPL

02c7101

REPL register serializer classes

076ae18

REPL absolutes paths

1c667c9

REPL experiment RemoteCache

c79fd8f

REPL patch fs.scandir

d758b43

REPL Use buffer polyfill with fastpaths

ef61b80

Expose TextDe/Encoder when executing tests

f5eaac4

Build REPL on CI

c619ccf

mischnic force-pushed the repl-v2-ide branch from ee8282a to c619ccf Compare November 7, 2023 17:34

REPL CI Alias for PRs

0025d0e

mischnic force-pushed the repl-v2-ide branch from 4df5993 to 0025d0e Compare November 11, 2023 15:21

Merge branch 'v2' into repl-v2-ide

3ffa307

Pass ref to GH deployment api

bcf6446

github-actions bot temporarily deployed to Preview November 12, 2023 21:20 Inactive

mischnic marked this pull request as ready for review November 12, 2023 21:23

devongovett reviewed Nov 13, 2023

View reviewed changes

Flow type ExtendedMemoryFS

3733258

github-actions bot temporarily deployed to Preview November 25, 2023 08:54 Inactive

mischnic added 4 commits November 25, 2023 21:40

Use react

49849dd

Update codemirror

7370b45

react-resizable-panels

67971ee

Lint

53f6482

mischnic force-pushed the repl-v2-ide branch from 439e69b to 53f6482 Compare November 25, 2023 20:47

github-actions bot temporarily deployed to Preview November 25, 2023 21:02 Inactive

Fixup runtime resolver paths

7c40e98

github-actions bot temporarily deployed to Preview November 26, 2023 10:21 Inactive

mischnic added 3 commits December 5, 2023 20:16

Merge branch 'v2' into repl-v2-ide

e1e10c9

Revert __filename change

dccf749

New REPLRuntimesResolver implementation

9ebb534

mischnic commented Dec 5, 2023

View reviewed changes

github-actions bot temporarily deployed to Preview December 5, 2023 21:27 Inactive

mischnic requested a review from devongovett December 5, 2023 21:30

Merge branch 'v2' into repl-v2-ide

d753476

github-actions bot temporarily deployed to Preview December 7, 2023 10:34 Inactive

mischnic added 2 commits December 13, 2023 11:40

Merge branch 'v2' into repl-v2-ide

6a7f534

Merge branch 'v2' into repl-v2-ide

f1f584c

github-actions bot temporarily deployed to Preview December 14, 2023 19:42 Inactive

Merge branch 'v2' into repl-v2-ide

43b3a86

# Conflicts: # yarn.lock

github-actions bot temporarily deployed to Preview January 3, 2024 09:49 Inactive

Fix versions

745d2d4

github-actions bot temporarily deployed to Preview January 3, 2024 10:57 Inactive

devongovett approved these changes Jan 4, 2024

View reviewed changes

Merge branch 'v2' into repl-v2-ide

84b7388

github-actions bot temporarily deployed to Preview January 4, 2024 19:07 Inactive

mischnic merged commit 61effd4 into v2 Jan 4, 2024
15 of 17 checks passed

mischnic deleted the repl-v2-ide branch January 4, 2024 19:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REPL #9365

REPL #9365

mischnic commented Nov 7, 2023 •

edited

mischnic commented Nov 11, 2023 •

edited

mischnic commented Nov 12, 2023

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 •

edited

devongovett commented Nov 12, 2023

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 •

edited

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 •

edited

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 •

edited

devongovett left a comment

devongovett Nov 13, 2023

mischnic Nov 13, 2023 •

edited

devongovett Nov 13, 2023

mischnic Nov 13, 2023 •

edited

mischnic Dec 5, 2023

mischnic Dec 5, 2023

REPL #9365

REPL #9365

Conversation

mischnic commented Nov 7, 2023 • edited

mischnic commented Nov 11, 2023 • edited

mischnic commented Nov 12, 2023

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 • edited

devongovett commented Nov 12, 2023

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 • edited

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 • edited

devongovett commented Nov 12, 2023

mischnic commented Nov 12, 2023 • edited

devongovett left a comment

Choose a reason for hiding this comment

devongovett Nov 13, 2023

Choose a reason for hiding this comment

mischnic Nov 13, 2023 • edited

Choose a reason for hiding this comment

devongovett Nov 13, 2023

Choose a reason for hiding this comment

mischnic Nov 13, 2023 • edited

Choose a reason for hiding this comment

mischnic Dec 5, 2023

Choose a reason for hiding this comment

mischnic Dec 5, 2023

Choose a reason for hiding this comment

mischnic commented Nov 7, 2023 •

edited

mischnic commented Nov 11, 2023 •

edited

mischnic commented Nov 12, 2023 •

edited

mischnic commented Nov 12, 2023 •

edited

mischnic commented Nov 12, 2023 •

edited

mischnic commented Nov 12, 2023 •

edited

mischnic Nov 13, 2023 •

edited

mischnic Nov 13, 2023 •

edited