Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator-eslint: support eslint ^7.0.0 in devDeps and peerDeps #8997

Merged
merged 3 commits into from
May 10, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 9, 2023

↪️ Pull Request

  • validator-eslint: support eslint ^7.0.0 as well as existing ^6.0.0 in devDeps and peerDeps
    • Update lockfile to use eslint ^7.0.0 by default. This dedupes eslint in the lockfile.
    • Preliminary tests indicate it works fine with eslint 7 out of the box.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@legobeat
Copy link
Contributor Author

legobeat commented May 9, 2023

@mischnic @mattcompiles May the GitHub Action workflows for this PR be unlocked kind sers? 👼

@mischnic
Copy link
Member

mischnic commented May 9, 2023

Looks like you'll need some of the changes from #8580 to fix the lint errors

@legobeat legobeat force-pushed the validator-support-eslint-7 branch from c28d640 to 84422e7 Compare May 10, 2023 01:57
@legobeat legobeat marked this pull request as ready for review May 10, 2023 01:57
@legobeat legobeat force-pushed the validator-support-eslint-7 branch from 84422e7 to 5d4e124 Compare May 10, 2023 02:00
@legobeat
Copy link
Contributor Author

legobeat commented May 10, 2023

Looks like you'll need some of the changes from #8580 to fix the lint errors

Cheers!

lint passes locally as of 5d4e124.

@mischnic
Copy link
Member

You also need to add the flowconfig change from #8580

@legobeat legobeat force-pushed the validator-support-eslint-7 branch from eb0a9e6 to 4a5f105 Compare May 10, 2023 07:02
@legobeat
Copy link
Contributor Author

legobeat commented May 10, 2023

Breaking Benchmarks action addressed in parcel-bundler/parcel-benchmark-action#93 and parcel-bundler/parcel-benchmark-action#94

@legobeat
Copy link
Contributor Author

legobeat commented May 10, 2023

Integration tests run fine on Node.js 16 on Windows: https://github.com/parcel-bundler/parcel/actions/runs/4934084435/jobs/8818729879?pr=8997

  1438 passing (7m)
  78 pending

But fail on Node.js 14 on Windows: https://github.com/parcel-bundler/parcel/actions/runs/4934084435/jobs/8818729522?pr=8997

 1437 passing (7m)
  78 pending
  1 failing

  1) cache
       dev deps
         should support yarn pnp:
     Error: EPERM: operation not permitted, rename 'D:\a\parcel\parcel\packages\core\integration-tests\test\input\goc5azngifv\node_modules' -> 'D:\a\parcel\parcel\packages\core\integration-tests\test\input\goc5azngifv\pnp'
      at Object.renameSync (fs.js:798:3)
      at setup (test\/cache.js:4077:16)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)
      at testCache (test\/cache.js:80:7)
      at Context.<anonymous> (test\/cache.js:4063:17)



error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: C:\hostedtoolcache\windows\node\14.21.3\x64\node.exe
Arguments: C:\npm\prefix\node_modules\yarn\lib\cli.js test-ci
Directory: D:\a\parcel\parcel\packages\core\integration-tests
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspace for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Perhaps it's about time to drop support for Node.js 14 anyway nowthat it's EoL..?

@mischnic mischnic merged commit 0b7187b into parcel-bundler:v2 May 10, 2023
14 of 16 checks passed
@legobeat legobeat deleted the validator-support-eslint-7 branch May 10, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants