Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agawrys/lightning css entries fix #8544

Closed
wants to merge 2 commits into from

Conversation

AGawrys
Copy link
Contributor

@AGawrys AGawrys commented Oct 15, 2022

↪️ Pull Request

This PR allows for bundles within the experimental bundler to have multiple entries, which fixes some test cases for the lightning-css branch

There's still a failing test from css-modules but it's not from this change, rather, its left over from the tests failing on the lightingcss branch

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.00s +108.00ms ⚠️
Cached 409.00ms -33.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 115.00ms -227.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 117.00ms -226.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 117.00ms -226.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 7.36s -346.00ms
Cached 347.00ms -13.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 580.02kb +0.00b 5.00s -435.00ms 🚀

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@AGawrys AGawrys closed this Nov 3, 2022
@AGawrys AGawrys reopened this Nov 3, 2022
@devongovett
Copy link
Member

Played around with this some more, and I think it's more complicated now (esp with manual shared bundles in the mix). It's not so easy to know which ones are "entries" or not. I implemented a different approach within the CSS packager in #8492 which traverses the bundle and collects any assets that are reachable from nowhere except the bundle root. That seems to work pretty well and solves the immediate issue. If we need support for multi-entry bundles for another purpose later we can revisit, but gonna close this one for now.

@devongovett devongovett closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants