Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sec): remove MSIE support to allow upgrading to vuln-free dompurify v3 #3827

Merged

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Feb 18, 2025

Resolve #3819

Remove MSIE support as CVE-2025-26791 affects dompurify v2 and the only resolution is to bump to dompurify v3. However, the new major version dropped support for MSIE so jspdf must do the same.

…ify` v3

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Copy link
Contributor Author

hainenber commented Feb 18, 2025

wait, hold up. There are more IE support references across the codebase. One more commit incoming

Above statement is obsolete. All MSIE ref removed

Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Copy link
Contributor Author

I removed all proper MSIE references in the codebase. The generated polyfills might not needed anymore but I keep it as safe harness since older browsers can constitute Chrome/Firefox early versions as well.

Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber force-pushed the fix/remove-msie-support-to-fix-sec-vuln branch 3 times, most recently from afa6c67 to b344dc1 Compare February 18, 2025 15:05
Copy link

@Rylab Rylab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HackbrettXXX HackbrettXXX merged commit 7aa332e into parallax:master Feb 19, 2025
7 checks passed
@HackbrettXXX
Copy link
Collaborator

Thank you for the PR. I'll release it now.

@hainenber hainenber deleted the fix/remove-msie-support-to-fix-sec-vuln branch March 22, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dompurify dependency
3 participants