Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: catch type error when decoding base64url signature #569

Merged
merged 4 commits into from Sep 1, 2023
Merged

refactor: catch type error when decoding base64url signature #569

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd0eeb1
Catch type error when decoding signature
lboynton Sep 1, 2023
6eb197e
simplify
lboynton Sep 1, 2023
72d6679
Throw more appropriate error
lboynton Sep 1, 2023
edc54e4
fix scoping
lboynton Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/jws/flattened/verify.ts
View file
Open in desktop
Expand Up @@ -169,7 +169,12 @@ export async function flattenedVerify(
encoder.encode('.'),
typeof jws.payload === 'string' ? encoder.encode(jws.payload) : jws.payload,
)
const signature = base64url(jws.signature)
let signature: Uint8Array
try {
signature = base64url(jws.signature)
} catch {
throw new JWSInvalid('Failed to parse the base64url encoded signature')
}
const verified = await verify(alg, key, signature, data)

if (!verified) {
Expand Down