Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provided PAT for merging phase #155

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Use provided PAT for merging phase #155

merged 1 commit into from
Jun 28, 2023

Conversation

kachick
Copy link
Collaborator

@kachick kachick commented Jun 28, 2023

Closes #154

#151 (comment) に書いたように、マージ段階でPATを使うようにしました。

理由

マージされた時に他のアクションを走らせるのと、 #154#153 と連続で起きたからか

GraphQL: refusing to allow a GitHub App to create or update workflow `.github/workflows/merge-bot-pr.yml` without `workflows` permission (mergePullRequest)

というエラーが出ているからです。
自分のリポジトリでもこれは出てきてて、リベースしたら直りました。 GitHub CLI が最近このAPIを GraphQL 経由に変えて、RESTと微妙に違って制限があるとかかもしれませんが謎です。 cli/cli#7574 (comment) とかも微妙に違いそうだけど・・・ 🤔

timeout-minutes: 30
with:
github-token: '${{ secrets.GITHUB_TOKEN }}'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kachick/wait-other-jobs#523 で不要にしました

@pankona
Copy link
Owner

pankona commented Jun 28, 2023

なるほどー

@pankona pankona merged commit eb67111 into pankona:main Jun 28, 2023
4 checks passed
@kachick
Copy link
Collaborator Author

kachick commented Jun 28, 2023

あざます!

@kachick kachick deleted the prefer-pat-for-merge branch June 28, 2023 12:41
pankona added a commit that referenced this pull request Jul 10, 2023
Partially revert #155 for non PAT again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants