Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPS: Bump to 1.26 proper for Python 3.12 #55175

Merged
merged 5 commits into from
Sep 19, 2023
Merged

DEPS: Bump to 1.26 proper for Python 3.12 #55175

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38cee86
DEPS: Bump to 1.26 proper for Python 3.12
lithomas1 Sep 16, 2023
b2d31a6
Update unit-tests.yml
lithomas1 Sep 16, 2023
c9ce8b0
Update unit-tests.yml
lithomas1 Sep 17, 2023
f709f4c
revert hack
lithomas1 Sep 19, 2023
94545b8
Merge branch 'main' into bump-np-126
lithomas1 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Expand Up @@ -234,7 +234,8 @@ jobs:
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-asyncio>=0.17 hypothesis>=6.46.1
# No longer possible to easily compile numpy > 1.26 from source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes the source install difficult?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this too. Are the tests not even able to run due to installing numpy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numpy needs a BLAS which is not present on Github Actions to build, by default.

I didn't feel like spending time to fiddle around with the config settings for 32-bit (given its probably going to be removed sometime soon-ish), so I just left it. IMO, it's not the end of the world that its pinned, but if you want me to try to fiddle around, I can set some time towards the end of this week.

Copy link
Member

@mroeschke mroeschke Sep 18, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to this failure fix? ebca6df

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice.

Thanks for the fix!

python -m pip install --no-cache-dir versioneer[toml] cython "numpy<1.26" python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-asyncio>=0.17 hypothesis>=6.46.1
python -m pip install --no-cache-dir --no-build-isolation -e .
python -m pip list --no-cache-dir
export PANDAS_CI=1
Expand Down
6 changes: 2 additions & 4 deletions pyproject.toml
View file
Open in desktop
Expand Up @@ -10,8 +10,7 @@ requires = [
# we don't want to force users to compile with 1.25 though
# (Ideally, in the future, though, oldest-supported-numpy can be dropped when our min numpy is 1.25.x)
"oldest-supported-numpy>=2022.8.16; python_version<'3.12'",
# TODO: This needs to be updated when the official numpy 1.26 comes out
"numpy>=1.26.0b1; python_version>='3.12'",
"numpy>=1.26.0; python_version>='3.12'",
"versioneer[toml]"
]

Expand All @@ -32,8 +31,7 @@ requires-python = '>=3.9'
dependencies = [
"numpy>=1.22.4; python_version<'3.11'",
"numpy>=1.23.2; python_version=='3.11'",
# TODO: This needs to be updated when the official numpy 1.26 comes out
"numpy>=1.26.0b1; python_version>='3.12'",
"numpy>=1.26.0; python_version>='3.12'",
"python-dateutil>=2.8.2",
"pytz>=2020.1",
"tzdata>=2022.1"
Expand Down