Added TypeAlias

[sjdex]

• closes STYLE use TypeAlias and upgrade ruff #52448
• All code checks passed.

[twoertwein]

These changes also caused errors for mypy&pyright: https://github.com/pandas-dev/pandas/actions/runs/4620671070/jobs/8171100725?pr=52452

If

no_default: Final[TypeAlias] = _NoDefault.no_default
NoDefault: TypeAlias = Literal[_NoDefault.no_default]

doesn't work, you can suppress those errors.

[twoertwein]

Might need to ignore these two lines, mypy reports many errors like these:

error: Expression of type "TypeAlias" cannot be assigned to parameter of type "bool | Literal[_NoDefault.no_default]"
Type "TypeAlias" cannot be assigned to type "bool | Literal[_NoDefault.no_default]"

[twoertwein]

typing.TypeAlias exists only since 3.10 - while this doesn't cause runtime issues, mypy complains about it. You can change the imports probably to from typing_extensions import TypeAlias

[sjdex]

After running pre-commit run ruff --all-files , getting around 26 errors related to line formatting. See below

Do I need to fix this in this Issue itself, or is there going to be a seperate one.?

[MarcoGorelli]

they'd need to be fixed as part of the same PR, CI need to be green before merging

what's causing the long lines now?

[sjdex]

Not sure whats causing this, as lines are within limit of 88 chars. Breaking up the line solves this issue though.

[MarcoGorelli]

if you push a commit I can take a look

[MarcoGorelli]

I think this is a false-positive in ruff itself - I've reported it to them here: astral-sh/ruff#3902

let's put this on hold until they get back to us

[MarcoGorelli]

I think this is a false-positive in ruff itself - I've reported it to them here: charliermarsh/ruff#3902

let's put this on hold until they get back to us

from astral-sh/ruff#3902 , it looks like we may just have to further split the lines

[twoertwein]

I'm quite sure we want to keep those? can they be a TypeAlias?

[snorfyang]

Sure they can. It seems that TypeAlias is imported from the wrong library. It should be imported from typing_extensions.