Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPS: Bump to 1.26 proper for Python 3.12 #55175

Merged
merged 5 commits into from Sep 19, 2023
Merged

DEPS: Bump to 1.26 proper for Python 3.12 #55175

merged 5 commits into from Sep 19, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added Dependencies Required and optional dependencies Python 3.12 labels Sep 16, 2023
@lithomas1 lithomas1 added this to the 2.1.1 milestone Sep 16, 2023
WillAyd
WillAyd reviewed Sep 17, 2023
View reviewed changes
.github/workflows/unit-tests.yml Outdated
@@ -234,7 +234,8 @@ jobs:
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-asyncio>=0.17 hypothesis>=6.46.1
# No longer possible to easily compile numpy > 1.26 from source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes the source install difficult?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this too. Are the tests not even able to run due to installing numpy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numpy needs a BLAS which is not present on Github Actions to build, by default.

I didn't feel like spending time to fiddle around with the config settings for 32-bit (given its probably going to be removed sometime soon-ish), so I just left it. IMO, it's not the end of the world that its pinned, but if you want me to try to fiddle around, I can set some time towards the end of this week.

Copy link
Member

@mroeschke mroeschke Sep 18, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to this failure fix? ebca6df

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice.

Thanks for the fix!

@cdce8p cdce8p mentioned this pull request Sep 17, 2023
Closed
32 tasks
@mroeschke mroeschke merged commit 6a65cfd into pandas-dev:main Sep 19, 2023
39 checks passed
@mroeschke
Copy link
Member

Thanks @lithomas1

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 19, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 19, 2023
@lithomas1 @meeseeksmachine
Backport PR pandas-dev#55175: DEPS: Bump to 1.26 proper for Python 3.12
3517d65
@lithomas1 lithomas1 deleted the bump-np-126 branch September 19, 2023 18:26
mroeschke pushed a commit that referenced this pull request Sep 19, 2023
@meeseeksmachine @lithomas1
Backport PR #55175 on branch 2.1.x (DEPS: Bump to 1.26 proper for Pyt…
cb7ea72 
…hon 3.12) (#55203)

Backport PR #55175: DEPS: Bump to 1.26 proper for Python 3.12

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
hedeershowk pushed a commit to hedeershowk/pandas that referenced this pull request Sep 20, 2023
@lithomas1 @hedeershowk
DEPS: Bump to 1.26 proper for Python 3.12 (pandas-dev#55175)
4ba0805 
* DEPS: Bump to 1.26 proper for Python 3.12

* Update unit-tests.yml

* Update unit-tests.yml

* revert hack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies Python 3.12
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lithomas1 @mroeschke @WillAyd