baseline-java-versions: Remove setting sourceCompatibility in task action #3060
+115
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
In #2136, we forced setting the source compatibility in a task action to work around a bug in Gradle where it would add the
--release
flag unnecessarily, which meant we could not use--add-exports
or--add-opens
.This has a couple of problems:
sourceCompatibility
and (targetCompatibility
if it is less than thesourceCompatibility
). I want to do this for palantir-java-format to support running in older compiler versions.This bug was fixed in Gradle 8, so we don't need to do this any more.
After this PR
==COMMIT_MSG==
For baseline-java-versions (for Gradle >=8), do not explicitly set the
sourceCompatibility
of Java compilations in a task action before the task runs.==COMMIT_MSG==
Possible downsides?