Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline-java-versions: Remove setting sourceCompatibility in task action #3060

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Mar 6, 2025

Before this PR

In #2136, we forced setting the source compatibility in a task action to work around a bug in Gradle where it would add the --release flag unnecessarily, which meant we could not use --add-exports or --add-opens.

This has a couple of problems:

  1. Since it access mutable task state inside a task action, it's not good Gradle:
    1. The task cannot be run in parallel with other tasks in the same project
    2. Not configuration cache compatible
  2. It prevents people from setting their own sourceCompatibility and (targetCompatibility if it is less than the sourceCompatibility). I want to do this for palantir-java-format to support running in older compiler versions.

This bug was fixed in Gradle 8, so we don't need to do this any more.

After this PR

==COMMIT_MSG==
For baseline-java-versions (for Gradle >=8), do not explicitly set the sourceCompatibility of Java compilations in a task action before the task runs.
==COMMIT_MSG==

Possible downsides?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…tion
@changelog-app
Copy link

changelog-app bot commented Mar 6, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

For baseline-java-versions (for Gradle >=8), do not explicitly set the sourceCompatibility of Java compilations in a task action before the task runs.

Check the box to generate changelog(s)

  • Generate changelog entry

Sorry, something went wrong.

@CRogers CRogers marked this pull request as ready for review March 6, 2025 17:30
@CRogers CRogers requested review from carterkozak and crogoz March 6, 2025 17:30
@bulldozer-bot bulldozer-bot bot merged commit 6c7b0a2 into develop Mar 7, 2025
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/remove-source-compatibility-setting branch March 7, 2025 09:16
@autorelease3
Copy link

autorelease3 bot commented Mar 7, 2025

Released 6.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants