-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Safe-logging] Infer lambda parameter safety from surrounding context #3050
Merged
+141
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30493ab
to
a11c086
Compare
Base automatically changed from
ald/safe-logging-lambda-assignment
to
develop
February 24, 2025 14:53
a11c086
to
869e27f
Compare
Generate changelog in
|
carterkozak
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, especially the test coverage!
Released 6.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Using a lambda's parameter as safe when we know it is unsafe isn't caught.
Unfortunately, the lambda parameter types passed in
SafetyPropagationTransfer#initialStore
fromForwardAnalysisImpl#getParameters
don't seem to contain the type annotations. However, they are present in theunderlyingAst
argument which is also given, so we can instead recompute the argument safety from the expected lambda type.After this PR
Builds on top of #3048, which handles checking the returned values in a lambda
==COMMIT_MSG==
[Safe-logging] Infer lambda parameter safety from surrounding context
==COMMIT_MSG==
Possible downsides?