Handle safety analysis for this
and super
references
#3041
Merged
+141
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Previously we failed to handle safety metadata for
this
andsuper
references similarly to other variable references. See the new tests for examples. Most notably, this meant one could implement aSafeLoggable
exception thusly without a warning:The danger is subtler than one might realize -- if such an exception is created with a known, safe message, it may be fine, however if it's constructed with a ctor that delegates to
public Throwable(Throwable cause)
, thencause.toString()
will be used as the exception message, which is almost certainly unsafe, even (or especially!) if the cause implementsSafeLoggable
due to the following:After this PR
==COMMIT_MSG==
Handle safety analysis for
this
andsuper
references==COMMIT_MSG==