Multi arch support #357
Merged
Multi arch support #357
+79
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacostas
force-pushed
the
multi-arch-support
branch
2 times, most recently
from
ace5290 to
957976e
Compare
6 tasks
pacostas
force-pushed
the
multi-arch-support
branch
from
957976e to
2fad871
Compare
|
@ForestEckhardt I updated freezer, rebased branch. Is ready for review :) |
|
LGTM, can you rebase the branch and check if the changes to |
pacostas
force-pushed
the
multi-arch-support
branch
from
2fad871 to
cb8fb1b
Compare
feat: multi-arch support for generating multi-arch directories
pacostas
force-pushed
the
multi-arch-support
branch
from
cb8fb1b to
466a877
Compare
|
@modulo11 thank you, i removed them and the tests are passing |
|
@ForestEckhardt I think this PR is ready for review/merge |
robdimsdale
approved these changes
Mar 4, 2025
| @@ -29,16 +29,15 @@ func testBuildpackStore(t *testing.T, when spec.G, it spec.S) { | |||
| fakeCacheManager = &fakes.CacheManager{} | |||
|
|
|||
| buildpackStore = occam.NewBuildpackStore() | |||
|
|
|||
| buildpackStore = buildpackStore.WithLocalFetcher(fakeLocalFetcher). | |||
There was a problem hiding this comment.
I don't think we needed to remove this - we could have kept it here, and later on we could have done buildpackStore = buildpackStore.WithTarget(). It would only override it for the specific tests that require it.
However, i think either option is fine, so no need to revert your changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge After
https://github.com/ForestEckhardt/freezerpackage.Summary
This PR does two things:
WithTargetswhich allows to download the proper buildpack architecture that is specified from that flag. If not specified, default value islinux/amd64.Use Cases
Checklist