Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filematchers follow symlinks #356

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

nicolasbender
Copy link
Contributor

@nicolasbender nicolasbender commented Jan 31, 2025

Summary

This change introduces a new feature that allows users to include checking symlinks to files in their file matcher tests.

Use Cases

When a user checks a file in an OCI image, using have_file() or have_file_with_content() would return false if the provided path was a symlink, regardless of the actual existence of the target file. With this feature, the functions now correctly follow symlinks to verify the existence and content of the target file.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Sorry, something went wrong.

@nicolasbender nicolasbender requested a review from a team as a code owner January 31, 2025 12:25
@nicolasbender nicolasbender added enhancement A new feature or request semver:minor A change requiring a minor version bump labels Feb 21, 2025
nicolasbender and others added 2 commits March 4, 2025 14:39
Follow symlinks

Co-authored-by: Johannes Dillmann <j.dillmann@sap.com>
Co-authored-by: Nicolas Bender <nicolas.bender@sap.com>
@modulo11 modulo11 merged commit 2d9980f into paketo-buildpacks:main Mar 4, 2025
7 checks passed
@modulo11 modulo11 deleted the follow-symlinks branch March 4, 2025 13:47
@pacostas pacostas mentioned this pull request Mar 10, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or request semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants