Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(reporter-svelte): deprecated svelte component type #246

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

ecelustka
Copy link
Contributor

Refactor deprecated component type in Svelte 4

sveltejs/svelte#8512

This PR resolves #245

@vercel
Copy link

vercel bot commented Jun 22, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @pablo-abc on Vercel.

@pablo-abc first needs to authorize it.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #246 (52b990b) into main (7a48fbf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          97       97           
  Lines        6805     6805           
  Branches     1160     1160           
=======================================
  Hits         6785     6785           
  Misses         20       20           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a48fbf...52b990b. Read the comment docs.

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
felte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:49pm

@pablo-abc
Copy link
Owner

Beautiful! Thanks a lot for the contribution <3

@pablo-abc pablo-abc merged commit f69de9c into pablo-abc:main Jun 22, 2023
5 checks passed
@ecelustka ecelustka deleted the refactor/svelte-component-type branch June 22, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Svelte 4] Invalid <ValidationMessage> Component types (@felte/reporter-svelte)
2 participants