Update integration tests to support all platforms, including Windows #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2022
|
Thanks again for this functionality @aarongoldenthal. The test runs have expired but, since it was previously approved, and nothing else has arrived in |
stevenleija
added a commit
to stevenleija/pa11y-ci-stevenleija
that referenced
this pull request
May 2, 2024
* origin/master: Bump ip from 1.1.8 to 1.1.9 Update to Pa11y v7 and other dependency updates (pa11y#231) Version `3.1.0` (pa11y#226) Add JavaScript config example to README (pa11y#197) Bump @babel/traverse from 7.16.0 to 7.23.3 (pa11y#222) Bump semver from 6.3.0 to 6.3.1 (pa11y#221) Bump json5 from 2.2.0 to 2.2.3 (pa11y#219) Bump ansi-regex from 3.0.0 to 3.0.1 (pa11y#218) Bump debug from 4.1.1 to 4.3.1 (pa11y#216) Bump node-fetch from 2.6.1 to 2.6.7 (pa11y#217) Upgrade to `pa11y@6.2.3`, add publishing workflow (pa11y#213) Update integration tests to support all platforms, including Windows (pa11y#177) # Conflicts: # bin/pa11y-ci.js # package-lock.json # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the integration tests to support all platforms, including Windows. The current integration tests fail on Windows for two reasons:
startWebsitefunction and JSON output tests rely on POSIX-style paths, so encounter errors when simply concatenated with Windows paths. Thepath.resolveorpath.joinfunctions are used instead.cliCallfunction that executes the tests assumes thebinfile is executable, which works in *nix systems, but is not true in Windows since it ignores the shebang. This function is updated to explicitly run thenodecommand against thebinfile.This also adds Windows and Mac test cases to the GitHub Actions, matching pa11y/pa11y#640.