bugfix: show correct window title when opening a public link #12225
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
mzner
force-pushed
the
bugfix/broken-title-for-public-files-link
branch
from
821f439 to
0c981fa
Compare
LukasHirt
reviewed
Feb 27, 2025
| @@ -282,9 +282,16 @@ export default defineComponent({ | |||
| const isCurrentFolderEmpty = computed( | |||
| () => unref(resourcesViewDefaults.paginatedResources).length < 1 | |||
| ) | |||
| const isPublicFile = (spaceData: SpaceResource) => unref(spaceData).driveType === 'public' | |||
There was a problem hiding this comment.
There is already function in web-client for this:
mzner
force-pushed
the
bugfix/broken-title-for-public-files-link
branch
from
0c981fa to
9731ef1
Compare
LukasHirt
approved these changes
Feb 27, 2025
mzner
force-pushed
the
bugfix/broken-title-for-public-files-link
branch
from
9731ef1 to
c8d6a49
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the window title is incorrectly shown when user opens a public link.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: