-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add input bun-version-file #76
feat: add input bun-version-file #76
Conversation
README.md
Outdated
| Name | Description | Default | Examples | | ||
| ------------------- | ------------------------------------------------------ | ----------- | ------------------------------- | | ||
| `bun-version` | The version of Bun to download and install. | `latest` | `canary`, `1.0.0`, `1.0.x` | | ||
| `bun-version-file` | The version of Bun to download and install from file. | `undefined` | `canary`, `1.0.0`, `1.0.x` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong examples for bun-version-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lemme check
I'm not a big fan of |
Imo this config very useful for monorepo when using single workflow and have diferrent bun version between package, just create .bumrc file inside each package. And this config can make consistency bun installed version between when running in local or ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I'll create branch called dev
because I want to do some more changes
oke thanks @xhyrom |
* feat: add input bun-version-file (#76) * feat: add input for bun-version-file * docs: update example bun version file * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * refactor: reduce read from file code * [autofix.ci] apply automated fixes * feat: read from all known files if not specified * [autofix.ci] apply automated fixes * fix: just continue if file doesnt exist * [autofix.ci] apply automated fixes * fix: return output if found version * [autofix.ci] apply automated fixes * fix: make whitespace in .tool-versions optional * [autofix.ci] apply automated fixes * log loglog * [autofix.ci] apply automated fixes * log log log * [autofix.ci] apply automated fixes * better warnings, fix ci failing * [autofix.ci] apply automated fixes * feat: log obtained version * [autofix.ci] apply automated fixes * build: bump version * [autofix.ci] apply automated fixes * fix: add .zip extension if it's not present Workaround for actions/toolkit#1179 Fixes #79 * [autofix.ci] apply automated fixes * docs: add comment for easier understanding * ci: more readable version * ci: match name * docs: add package.json and .tool-versions to bun-version-file examples * ci: add cache test * ci: install another pkg for cache test * ci: install more pkgs for cache test * ci: block all trusted deps in cache test * ci: more deps for cache test * ci: cache test should cache * refactor: dont try all files if not defined * [autofix.ci] apply automated fixes * ci: remove cache test * feat: support .bunrc * [autofix.ci] apply automated fixes * refactor: .bun-version instead .bunrc * [autofix.ci] apply automated fixes * feat: add bun paths and url to output Fixes #81 * [autofix.ci] apply automated fixes * ci: test for .bun-version * feat: make .bun-version as default in bun-version-file * ci: remove cache before test * ci: remove cache before test * ci: remove cache before test * ci: remove cache before test --------- Co-authored-by: Ade Hery Shopyan <51158020+adeherysh@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Is this supposed to be called |
It is not supposed to be called |
@Jarred-Sumner The example given is |
Yep, thanks for flagging |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@​adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@​xHyroM](https://togithub.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday after 9am before 5pm" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Fixed in #86, thanks for flagging :) |
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@​adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@​xHyroM](https://togithub.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mheob/config).
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://redirect.github.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://redirect.github.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://redirect.github.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://redirect.github.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://redirect.github.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://redirect.github.com/oven-sh/setup-bun/pull/76) by [@​adeherysh](https://redirect.github.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://redirect.github.com/oven-sh/setup-bun/pull/80) by [@​xHyroM](https://redirect.github.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/grafbase/grafbase). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
What does this PR do?