AssertionFailedError: Enable Java-behavior for late cause initialisation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java deals differently for a cause of null and an unset cause. If the cause is initialized with null subsequent calls to initCause() will fail. If the cause is unset a subsequent call to initCause() works. This solution introduces a "flag-exception" to indicate that no cause has been set and thus the cause gets only initialized if the cause has been explicitly set by the API user.
|
Good catch! 👍 Please review the newly added CONTRIBUTING guidelines. If you agree to the CLA, please add the following lines to your pull request description: ---
I hereby agree to the terms of the Open Test Alliance Contributor License Agreement.Thanks! |
TWiStErRob
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
This would fix #70, what's missing to merge this? I would be happy to revive if author has abandoned it.
|
@mmichaelis @TWiStErRob Thanks and sorry for the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java deals differently for a cause of null and an unset cause. If the cause is initialized with null subsequent calls to initCause() will fail. If the cause is unset a subsequent call to initCause() works.
This solution introduces a "flag-exception" to indicate that no cause has been set and thus the cause gets only initialized if the cause has been explicitly set by the API user.
To analyze the problem you can have a look at
Throwable.initCause(): If the cause is unset it's a self-reference to the exception itself and serves as indicator for cause is unset. If you callinitCausewith a cause already set it will fail with anIllegalStateException.I hereby agree to the terms of the Open Test Alliance Contributor License Agreement.