Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ ProjectPackageClient: pass client to RunScorecard #4096

Merged
merged 2 commits into from May 13, 2024

Conversation

raghavkaul
Copy link
Contributor

What kind of change does this PR introduce?

Pass ProjectPackageClient to RunScorecard. This will allow raw data collection/probes to make use of the new interface.

@raghavkaul raghavkaul requested a review from a team as a code owner May 8, 2024 21:16
@raghavkaul raghavkaul requested review from naveensrinivasan and spencerschrock and removed request for a team May 8, 2024 21:16
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be tweaking this again as I address #3717 , so I'll add you as a reviewer on that one.

pkg/scorecard.go Show resolved Hide resolved
@spencerschrock spencerschrock changed the title 🌱 ProjectPackageClient: pass client to RunScorecard ⚠️ ProjectPackageClient: pass client to RunScorecard May 9, 2024
@raghavkaul raghavkaul merged commit 32b5963 into ossf:main May 13, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants