Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 SAST: dedupe and add Pysa and Qodana probe #3743

Merged
merged 14 commits into from
Jan 2, 2024

Conversation

DavidKorczynski
Copy link
Contributor

@DavidKorczynski DavidKorczynski commented Dec 19, 2023

What kind of change does this PR introduce?

Adds a probe checking the presence of Pysa SAST Github action (https://github.com/facebook/pysa-action) and Qodana (https://www.jetbrains.com/qodana/)

Additionally, refactors duplicate code throughout the checking logic.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Scorecard will not recognize Pysa/Qodana scanning as a SAST action

What is the new behavior (if this is a feature change)?**

Scorecard will recognize Pysa/Qodana scanning as a SAST action.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Ref: #2318

Fixes: #3709

Fixes: #3745

Special notes for your reviewer

Does this PR introduce a user-facing change?

Yes, in that it will change scoring of projects that use Pysa and users may now see Pysa-related details in the output.

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


Signed-off-by: David Korczynski <david@adalogics.com>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #3743 (7367102) into main (6c2a266) will increase coverage by 2.05%.
The diff coverage is 69.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3743      +/-   ##
==========================================
+ Coverage   66.84%   68.90%   +2.05%     
==========================================
  Files         227      229       +2     
  Lines       15353    15372      +19     
==========================================
+ Hits        10263    10592     +329     
+ Misses       4483     4129     -354     
- Partials      607      651      +44     

Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski DavidKorczynski changed the title 馃尡 Add SAST Pysa probe 馃尡 Add SAST Pysa and Qodana probe Dec 19, 2023
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
Copy link
Contributor Author

Putting this in draft as I'll tackle #3745 first

Ref: ossf#3745

Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski DavidKorczynski changed the title 馃尡 Add SAST Pysa and Qodana probe 馃尡 SAST: dedupe and add SAST Pysa and Qodana probe Dec 21, 2023
@DavidKorczynski DavidKorczynski marked this pull request as ready for review December 21, 2023 00:56
@DavidKorczynski DavidKorczynski changed the title 馃尡 SAST: dedupe and add SAST Pysa and Qodana probe 馃尡 SAST: dedupe and add Pysa and Qodana probe Dec 21, 2023
Signed-off-by: David Korczynski <david@adalogics.com>
checks/raw/sast.go Outdated Show resolved Hide resolved
checks/raw/sast.go Outdated Show resolved Hide resolved
checks/raw/sast.go Outdated Show resolved Hide resolved
checks/raw/sast.go Outdated Show resolved Hide resolved
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
@spencerschrock
Copy link
Contributor

/scdiff generate SAST

Copy link

github-actions bot commented Jan 2, 2024

Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@spencerschrock spencerschrock enabled auto-merge (squash) January 2, 2024 17:15
@spencerschrock spencerschrock merged commit 99c455b into ossf:main Jan 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

de-duplicate SAST workflow scanning BUG: Qodana does not count as a SAST tool
2 participants