Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove dependencydiff files and related tests #3053

Closed
wants to merge 1 commit into from

Conversation

naveensrinivasan
Copy link
Member

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

The dependencydiff package has been removed. 

- Remove depedencydiff as we are building something similar to this ossf/scorecard-action#1095

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #3053 (2c0ddfe) into main (0888bad) will decrease coverage by 5.33%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
- Coverage   62.91%   57.59%   -5.33%     
==========================================
  Files         166      136      -30     
  Lines       12461    11072    -1389     
==========================================
- Hits         7840     6377    -1463     
- Misses       4178     4302     +124     
+ Partials      443      393      -50     

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Stale pull request message

@spencerschrock
Copy link
Contributor

Given it's a breaking change, do we want to add it to the v5 tracker so we can do it at major bump? (I don't see anything dependents https://pkg.go.dev/github.com/ossf/scorecard/v4@v4.10.5/dependencydiff, but we can't know for sure)

In the short term we could mark as deprecated?

@naveensrinivasan
Copy link
Member Author

#3125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants