Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Add tie breaker when sorting changesets by RevisionID in tests. #2781

Merged
merged 4 commits into from
Mar 23, 2023
Merged

馃悰 Add tie breaker when sorting changesets by RevisionID in tests. #2781

merged 4 commits into from
Mar 23, 2023

Commits on Mar 22, 2023

  1. Remove duplicate RevisionID collision from changeset tests. 

    The map iteration order isn't deterministic and sorting the slices isn't good enough when the revision IDs are equal.

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8fc856e View commit details
    Browse the repository at this point in the history

  2. remove any potential sha collisions 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    bd45762 View commit details
    Browse the repository at this point in the history

  3. Revert deduplications. 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1d05beb View commit details
    Browse the repository at this point in the history

  4. Use ReviewPlatform as tie breaker. 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2eb88db View commit details
    Browse the repository at this point in the history