Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove unused code from changeset creation #2776

Merged
merged 1 commit into from
Mar 21, 2023
+214 −243
Merged

🌱 Remove unused code from changeset creation #2776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 1 addition & 13 deletions checks/raw/code_review.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,19 +183,7 @@ func getChangesets(commits []clients.Commit) []checker.Changeset {

// Changesets are returned in map order (i.e. randomized)
for ri := range changesetsByRevInfo {
// Ungroup all commits that don't have revision info
cs := changesetsByRevInfo[ri]
missing := revisionInfo{}
if ri == missing {
for i := range cs.Commits {
c := cs.Commits[i]
changesets = append(changesets, checker.Changeset{
Commits: []clients.Commit{c},
})
}
} else {
changesets = append(changesets, cs)
}
changesets = append(changesets, changesetsByRevInfo[ri])
}

return changesets
Expand Down