Skip to content

Commit

Permalink
🌱 specify golangci-lint version in action (#1353)
Browse files Browse the repository at this point in the history
* specify golangci-lint version in action

If we don't set it, the action uses the latest release.
Version changes should be controlled, as new linter versions
often lead to new findings which need to be dealt with.

Signed-off-by: Spencer Schrock <sschrock@google.com>

* use timeout instead of deadline

deadline was deprecated in 2019 and support was removed in v1.57.0 of golangci-lint

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
  • Loading branch information
spencerschrock committed Mar 26, 2024
1 parent 50aaf84 commit d58f6f3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ jobs:
cache: false # golangci/golangci-lint-action maintains its own cache
- uses: golangci/golangci-lint-action@3cfe3a4abbb849e10058ce4af15d205b6da42804 # v4.0.0
with:
version: v1.55.2
only-new-issues: true
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
run:
concurrency: 6
deadline: 5m
timeout: 5m
issues:
include:
# revive `package-comments` and `exported` rules.
Expand Down

0 comments on commit d58f6f3

Please sign in to comment.