Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests - signal/signal #274

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nathannaveen
Copy link
Contributor

@nathannaveen nathannaveen commented Dec 3, 2022

  • Included unit tests for internal/collector/signal/signal
  • Managed to get 100% coverage.

Signed-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com

- Included unit tests for internal/collector/signal/signal

Unit tests - signal/signal

- Included unit tests for internal/collector/signal/signal

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen marked this pull request as ready for review December 5, 2022 15:16
@nathannaveen
Copy link
Contributor Author

This was a bit of learning with reflection, which is newer to me.

@nathannaveen
Copy link
Contributor Author

@calebbrown, a friendly ping!

internal/collector/signal/signal_test.go Outdated Show resolved Hide resolved
internal/collector/signal/signal_test.go Outdated Show resolved Hide resolved
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Copy link
Contributor Author

@calebbrown A friendly ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants