Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tui): Implement conditional option #281

Closed

Conversation

Anavelyz
Copy link
Collaborator

@Anavelyz Anavelyz commented May 5, 2024

Pull Request description

If a user chooses certain options, this may lead to a new question or new options. To do this, it was necessary to implement the conditional option in ui.py.

Fixes #171

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved

@Anavelyz Anavelyz marked this pull request as draft May 5, 2024 23:49
@Anavelyz Anavelyz changed the title Implement conditional option feat(tui): Implement conditional option May 9, 2024
@Anavelyz Anavelyz marked this pull request as ready for review May 9, 2024 14:49
@xmnlab
Copy link
Contributor

xmnlab commented May 9, 2024

It is a good progress @Anavelyz ! thanks for working on that

checking the workflow, I think that if the user decide to not configure git, it should not add anything with git.

it will be a bit challenge ... but at least I think you should review https://github.com/osl-incubator/scicookie/blob/main/src/scicookie/hooks/post_gen_project.py#L328

maybe it should abort or skip the git commands there

maybe it should also remove the .github folder

@xmnlab
Copy link
Contributor

xmnlab commented May 9, 2024

does it make sense?

@xmnlab xmnlab mentioned this pull request May 14, 2024
11 tasks
@Anavelyz Anavelyz force-pushed the 171-implement-conditional-option branch from 113bd49 to aab0523 Compare May 21, 2024 18:52
@Anavelyz
Copy link
Collaborator Author

Anavelyz commented May 27, 2024

This was an attempt to resolve issue #171, unfortunately it was not successful 😞 so I will close the PR.

@Anavelyz Anavelyz closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the conditional option
2 participants