-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/partnumberwin10 #2603
Feature/partnumberwin10 #2603
Conversation
BartekDziurowicz
commented
Mar 18, 2024
- extend memorychip by partnumber infor for windows systems
- update tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2603 +/- ##
==========================================
- Coverage 87.05% 86.83% -0.22%
==========================================
Files 30 30
Lines 1313 1337 +24
Branches 183 189 +6
==========================================
+ Hits 1143 1161 +18
- Misses 98 104 +6
Partials 72 72 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition! Looks like we can fix mac and AIX too....
oshi-core/src/main/java/oshi/driver/windows/wmi/Win32PhysicalMemory.java
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/hardware/platform/unix/aix/AixGlobalMemory.java
Show resolved
Hide resolved
Thanks for this contribution! Appreciate your patience and addressing review comments. Added #2607 to follow up with other operating systems before the next release. |