Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/partnumberwin10 #2603

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

BartekDziurowicz
Copy link
Contributor

  • extend memorychip by partnumber infor for windows systems
  • update tests

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (f292522) to head (add3908).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2603      +/-   ##
==========================================
- Coverage   87.05%   86.83%   -0.22%     
==========================================
  Files          30       30              
  Lines        1313     1337      +24     
  Branches      183      189       +6     
==========================================
+ Hits         1143     1161      +18     
- Misses         98      104       +6     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition! Looks like we can fix mac and AIX too....

@dbwiddis
Copy link
Member

Thanks for this contribution! Appreciate your patience and addressing review comments.

Added #2607 to follow up with other operating systems before the next release.

@dbwiddis dbwiddis merged commit 5d520b7 into oshi:master Mar 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants