Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: run integration test on macos GH runners as well #75

Merged
merged 3 commits into from
Jan 5, 2024
Merged

tests: run integration test on macos GH runners as well #75

merged 3 commits into from
Jan 5, 2024

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Dec 22, 2023 •
edited

This is a rebase/update of #33 without hacks.

@mvo5 mvo5 mentioned this pull request Dec 22, 2023
Closed
@achilleas-k
Copy link
Member

Instead of relying on the journal for logs and losing the checks on macOS, we could run the podman run command without --rm and then fetch the logs with podman logs <container>.
Worth it?

@mvo5 mvo5 force-pushed the tmt-smoke-macos-2 branch 2 times, most recently from 0b82d93 to e5442c4 Compare December 22, 2023 14:00
@mvo5
Copy link
Collaborator Author

mvo5 commented Dec 22, 2023 •
edited

Instead of relying on the journal for logs and losing the checks on macOS, we could run the podman run command without --rm and then fetch the logs with podman logs <container>. Worth it?

Thanks! I love the suggestion - added now!

@mvo5 mvo5 changed the title tests: run integration test on macos as well tests: run integration test on macos GH runners as well Dec 22, 2023
@mvo5 mvo5 marked this pull request as ready for review December 23, 2023 16:52
lmilbaum
lmilbaum reviewed Dec 28, 2023
View reviewed changes
.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@mvo5 mvo5 force-pushed the tmt-smoke-macos-2 branch 3 times, most recently from 32d1052 to 119879e Compare January 2, 2024 10:47
@ondrejbudai
Copy link
Member

This test takes 50 minutes to run on the Github-hosted worker. Should we try deploying a self-hosted runner on our AWS machine?

@mvo5
Copy link
Collaborator Author

mvo5 commented Jan 4, 2024

This test takes 50 minutes to run on the Github-hosted worker. Should we try deploying a self-hosted runner on our AWS machine?

Great point - I setup our AWS machine as a self hosted runner and it finisehd in 14min. so definitely worth it. Self hosting on macOS in AWS is a bit of a PITA though because of actions/runner#947 and actions/runner#1056 - I will see what I can do about that.

@mvo5 mvo5 force-pushed the tmt-smoke-macos-2 branch 4 times, most recently from adc5984 to a0579f6 Compare January 4, 2024 15:59
@mvo5 mvo5 marked this pull request as draft January 4, 2024 15:59
@mvo5 mvo5 force-pushed the tmt-smoke-macos-2 branch 3 times, most recently from c42070b to 08230de Compare January 4, 2024 16:22
@mvo5 mvo5 marked this pull request as ready for review January 4, 2024 16:31
@mvo5 mvo5 force-pushed the tmt-smoke-macos-2 branch 3 times, most recently from 207e4e6 to 5541e90 Compare January 4, 2024 17:23
@mvo5
tests: run integration test on macos as well
707a068
@mvo5
tests: run macos test on self hosted runners
b72f9cb 
For reference the runner was setup as described in:
actions/runner#1056 (comment)

to workaround the issue described in the bugreport
actions/runner#1056
@mvo5
Copy link
Collaborator Author

mvo5 commented Jan 4, 2024

This test takes 50 minutes to run on the Github-hosted worker. Should we try deploying a self-hosted runner on our AWS machine?

Great point - I setup our AWS machine as a self hosted runner and it finisehd in 14min. so definitely worth it. Self hosting on macOS in AWS is a bit of a PITA though because of actions/runner#947 and actions/runner#1056 - I will see what I can do about that.

This is ready now, sorry that it took a bit, the self hosted follows the setup from actions/runner#1056 (comment) and is now running a macOS background service.

ondrejbudai
ondrejbudai approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍎 Go!

@ondrejbudai ondrejbudai added this pull request to the merge queue Jan 5, 2024
Merged via the queue into osbuild:main with commit 06b68ed Jan 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmilbaum lmilbaum lmilbaum left review comments

@ondrejbudai ondrejbudai ondrejbudai approved these changes

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvo5 @achilleas-k @ondrejbudai @lmilbaum