Pull syntax functions down into the relevant classes instead of relyi… #225
+459
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmook
reviewed
Jun 24, 2024
orbit-core/src/commonMain/kotlin/org/orbitmvi/orbit/syntax/SubStateContainerContext.kt
Show resolved
Hide resolved
mattmook
approved these changes
Jun 24, 2024
Rosomack
force-pushed
the
feature/syntax-cleanup
branch
from
159ec31 to
a85b630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time has come for long-overdue cleanup of our syntax. Historically, we used to support two syntaxes, but this has changed a long while back.
As such, it no longer makes sense to keep DSL functions as extensions. It's messy, creates an unnecessary generics hell and prevents concise generics syntax for some new features like
runOn.This does mean breaking changes due to imports that will no longer be valid / necessary. However, these changes would be simple to resolve.
Time to 🧹 !