fix: check empty registry name

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
oras-project · Mar 20, 2024 · b94b39b · b94b39b
1 parent 4503c31
commit b94b39b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/registry/reference.go b/registry/reference.go
@@ -192,7 +192,7 @@ func (r Reference) Validate() error {
 
 // ValidateRegistry validates the registry.
 func (r Reference) ValidateRegistry() error {
-	if uri, err := url.ParseRequestURI("dummy://" + r.Registry); err != nil || uri.Host != r.Registry {
+	if uri, err := url.ParseRequestURI("dummy://" + r.Registry); err != nil || uri.Host == "" || uri.Host != r.Registry {
 		return fmt.Errorf("%w: invalid registry %q", errdef.ErrInvalidReference, r.Registry)
 	}
 	return nil

diff --git a/registry/reference_test.go b/registry/reference_test.go
@@ -113,6 +113,10 @@ func TestParseReferenceUglies(t *testing.T) {
 			name: "missing registry",
 			raw:  "hello-world:linux",
 		},
+		{
+			name: "missing registry (issue #698)",
+			raw:  "/hello-world:linux",
+		},
 		{
 			name: "invalid repo name",
 			raw:  "localhost/UPPERCASE/test",