Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Tensorboard Integration #56

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Move Tensorboard Integration #56

merged 8 commits into from
Jan 10, 2024

Conversation

dheemantha-bhat
Copy link
Contributor

Motivation

Progress optuna/optuna#4484

Description of the changes
Move integration/tensorboard.py and its test from optuna/optuna

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (98c5f78) 7.40% compared to head (d54932b) 2.32%.
Report is 23 commits behind head on main.

Files Patch % Lines
optuna_integration/tensorboard.py 0.00% 59 Missing ⚠️
optuna_integration/fastaiv2.py 0.00% 3 Missing ⚠️
optuna_integration/fastaiv1.py 0.00% 2 Missing ⚠️
optuna_integration/chainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #56      +/-   ##
========================================
- Coverage   7.40%   2.32%   -5.09%     
========================================
  Files         12      13       +1     
  Lines         27      86      +59     
========================================
  Hits           2       2              
- Misses        25      84      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixed Sphinx warning

Co-authored-by: Kento Nozawa <k_nzw@klis.tsukuba.ac.jp>
Copy link

github-actions bot commented Jan 2, 2024

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jan 2, 2024
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. LGTM!
Please wait until the second review for the merge.

@not522 not522 removed the stale Exempt from stale bot labeling. label Jan 4, 2024
@not522
Copy link
Member

not522 commented Jan 9, 2024

I'll merge this PR after optuna/optuna#5161 is merged.

@not522 not522 self-assigned this Jan 9, 2024
@not522 not522 merged commit d619ad9 into optuna:main Jan 10, 2024
11 checks passed
@not522 not522 added this to the v3.6.0 milestone Jan 10, 2024
@not522 not522 added the compatibility Change that breaks compatibility. label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Change that breaks compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants