Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apiVersion match for standard K8s resources #2724

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

mnk
Copy link
Contributor

@mnk mnk commented Mar 9, 2025

The HasMetadata.getApiVersion(primaryResourceType) method return "/v1" for the ConfigMap type. Since the K8s owner reference uses "v1" instead, the secondary resource of a primary ConfigMap will not be tracked correctly.

Proposed fix for #2723

@openshift-ci openshift-ci bot requested review from metacosm and xstefank March 9, 2025 14:52
@mnk mnk force-pushed the owner_reference_api_version branch from 7f07e1a to abebe8b Compare March 9, 2025 18:40
@xstefank xstefank requested a review from csviri March 10, 2025 07:10
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesom, thx @mnk LGTM

The HasMetadata.getApiVersion(primaryResourceType) method return "/v1" for
the ConfigMap type. Since the K8s owner reference uses "v1" instead, the
secondary resource of a primary ConfigMap will not be tracked correctly.

Proposed fix for operator-framework#2723

Signed-off-by: Mathias Nicolajsen Kjaergaard <mnk@mnk.dk>
@csviri csviri force-pushed the owner_reference_api_version branch from abebe8b to 4eed1b5 Compare March 11, 2025 08:07
@csviri csviri merged commit a8a15b1 into operator-framework:main Mar 12, 2025
20 checks passed
@csviri
Copy link
Collaborator

csviri commented Mar 12, 2025

thank you @mnk !

@mnk mnk deleted the owner_reference_api_version branch March 12, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants