Fix apiVersion match for standard K8s resources #2724
Merged
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnk
commented
Mar 9, 2025
...core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/Mappers.java
Show resolved
Hide resolved
mnk
force-pushed
the
owner_reference_api_version
branch
from
7f07e1a to
abebe8b
Compare
csviri
approved these changes
Mar 10, 2025
The HasMetadata.getApiVersion(primaryResourceType) method return "/v1" for the ConfigMap type. Since the K8s owner reference uses "v1" instead, the secondary resource of a primary ConfigMap will not be tracked correctly. Proposed fix for operator-framework#2723 Signed-off-by: Mathias Nicolajsen Kjaergaard <mnk@mnk.dk>
csviri
force-pushed
the
owner_reference_api_version
branch
from
abebe8b to
4eed1b5
Compare
xstefank
approved these changes
Mar 12, 2025
|
thank you @mnk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HasMetadata.getApiVersion(primaryResourceType) method return "/v1" for the ConfigMap type. Since the K8s owner reference uses "v1" instead, the secondary resource of a primary ConfigMap will not be tracked correctly.
Proposed fix for #2723