Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: more strict delete condition #2722

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 9, 2025

This way it is easier to reason about the resource deletion.

Signed-off-by: Attila Mészáros a_meszaros@apple.com

@openshift-ci openshift-ci bot requested review from metacosm and xstefank March 9, 2025 13:01
@csviri csviri changed the title improve: logging on resource delete condition improve: stricter delete condition Mar 9, 2025
@csviri csviri changed the title improve: stricter delete condition improve: more strict delete condition Mar 9, 2025
Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but isn't this potentially breaking change?

@csviri
Copy link
Collaborator Author

csviri commented Mar 10, 2025

OK, but isn't this potentially breaking change?

Not really, it is a bit change in the behavior, but rather the previous one was confusing.

@csviri csviri requested a review from metacosm March 10, 2025 15:17
csviri added 5 commits March 10, 2025 16:22
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
format

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Add docs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri force-pushed the logging-resource-delete-condition branch from 82c5559 to 76819d5 Compare March 10, 2025 15:22
@csviri csviri merged commit 8b39f73 into main Mar 11, 2025
20 checks passed
@csviri csviri deleted the logging-resource-delete-condition branch March 11, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants