Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump docsy and hugo fix templating issue #2714

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Feb 28, 2025

I had issues running locally the site with newer hugi, this is actually a bug in docsy, this PR bumps the version of docsy and hugo and fixes the bug.

Signed-off-by: Attila Mészáros a_meszaros@apple.com

@openshift-ci openshift-ci bot requested review from metacosm and xstefank February 28, 2025 12:38
@csviri csviri changed the title chore: bump docsy and hugo [wip] chore: bump docsy and hugo Feb 28, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@csviri csviri marked this pull request as draft February 28, 2025 12:40
@csviri
Copy link
Collaborator Author

csviri commented Feb 28, 2025

Note that there is an issue with this locally, working on it.

@csviri
Copy link
Collaborator Author

csviri commented Feb 28, 2025

see also: google/docsy#2197 (comment)

@csviri csviri marked this pull request as ready for review February 28, 2025 13:11
@csviri csviri changed the title [wip] chore: bump docsy and hugo chore: bump docsy and hugo Feb 28, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@csviri csviri changed the title chore: bump docsy and hugo chore: bump docsy and hugo fix templating issue Feb 28, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri force-pushed the bump-hugo-and-docsy branch from 118a6de to 8e8d541 Compare February 28, 2025 15:09
Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I admit that I don't understand what this mermaid thing is :)

@csviri
Copy link
Collaborator Author

csviri commented Feb 28, 2025

However, I admit that I don't understand what this mermaid thing is :)

docsy and also now github supports diagrams using mermaid, basically in code you describe a diagram:
https://mermaid.js.org/

@csviri csviri merged commit 647317a into main Feb 28, 2025
20 checks passed
@csviri csviri deleted the bump-hugo-and-docsy branch February 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants