feat: enable deactivation of MDC logging #2699
Merged
+38
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <claprun@redhat.com>
csviri
approved these changes
Feb 23, 2025
|
We've had, iirc, two issues recently that involved MDC logging in some way and I forgot we even had it. Not sure many people actually know about it and/or use this, and, as this has a potential (small) impact, I figured we should probably enable deactivating that feature and maybe, in a future release, disable it by default, especially if we add support for OpenTelemetry for instance. |
|
Not sure if openTelemtry will affect logging. But this information is very useful, and easy to use just by adding it to the logging pattern. IMO it should be enabled by default (as it is now). |
xstefank
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun claprun@redhat.com