Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable deactivation of MDC logging #2699

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat: enable deactivation of MDC logging #2699

merged 1 commit into from
Feb 25, 2025

Conversation

metacosm
Copy link
Collaborator

Signed-off-by: Chris Laprun claprun@redhat.com

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm self-assigned this Feb 23, 2025
@metacosm metacosm requested review from csviri and xstefank February 23, 2025 07:43
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls ellaborate the reason / use case of this change?

LGTM

@metacosm
Copy link
Collaborator Author

metacosm commented Feb 23, 2025

We've had, iirc, two issues recently that involved MDC logging in some way and I forgot we even had it. Not sure many people actually know about it and/or use this, and, as this has a potential (small) impact, I figured we should probably enable deactivating that feature and maybe, in a future release, disable it by default, especially if we add support for OpenTelemetry for instance.

@csviri
Copy link
Collaborator

csviri commented Feb 23, 2025

Not sure if openTelemtry will affect logging. But this information is very useful, and easy to use just by adding it to the logging pattern. IMO it should be enabled by default (as it is now).

@metacosm metacosm merged commit b2106f0 into main Feb 25, 2025
71 checks passed
@metacosm metacosm deleted the mdc branch February 25, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants