-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s to 1.25 and go to 1.19 #260
bump k8s to 1.25 and go to 1.19 #260
Conversation
@laxmikantbpandhare It seems the |
I tried that command already but did not get anything for commit.
|
b78b3e3
to
52f0733
Compare
@laxmikantbpandhare it looks like the verify check is still failing based on some formatting errors. I think doing a |
Ah! yeah it was still failing. I made changes to it. |
2ea1076
to
176b00c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Seems like the |
If there are no major objections, I would like to see #261 merge first, as it isn't clear how much work it will be to update OLM to use the new k8s and go versions. /hold |
@awgreene - this will impact SDK effort operator-framework/operator-sdk#5937. @jmrodri @theishshah - Can we wait for this? |
Fyi #261 is just waiting on an |
#261 has merged. Fyi I'm cutting a new release so that we can use that in OLM. /hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, laxmikantbpandhare The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
81a86ee
to
c58f9b7
Compare
c58f9b7
to
d8791d7
Compare
updated format defs
5ec7ff7
to
88d2c56
Compare
Squashed commits and rebased after merge of #261 |
/lgtm |
/override go-apidiff |
@joelanford: Overrode contexts on behalf of joelanford: go-apidiff In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ready for review.